From: Ajay Singh <ajay.kathat@microchip.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] staging: wilc1000: allocate less memory
Date: Fri, 04 May 2018 04:56:08 +0000 [thread overview]
Message-ID: <20180504101408.261450a5@ajaysk-VirtualBox> (raw)
In-Reply-To: <20180503105655.GC5315@mwanda>
On Thu, 3 May 2018 13:56:55 +0300
Dan Carpenter <dan.carpenter@oracle.com> wrote:
> We should be allocating space for hidden_network_info structs. They
> are slightly smaller than hidden_network structs. This bug doesn't
> cause a runtime issue beyond the very small ammount of extra memory
> used.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Ajay Singh <ajay.kathat@microchip.com>
Thanks for submitting the changes by using correct structure size
for memory allocation.
>
> diff --git a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c
> b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c index
> 3ca0c97b0627..92322d6f061d 100644 ---
> a/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c +++
> b/drivers/staging/wilc1000/wilc_wfi_cfgoperations.c @@ -581,8 +581,8
> @@ wilc_wfi_cfg_alloc_fill_ssid(struct cfg80211_scan_request
> *request, int i; int slot_id = 0;
>
> - ntwk->net_info = kcalloc(request->n_ssids,
> - sizeof(struct hidden_network),
> GFP_KERNEL);
> + ntwk->net_info = kcalloc(request->n_ssids,
> sizeof(*ntwk->net_info),
> + GFP_KERNEL);
> if (!ntwk->net_info)
> goto out;
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
prev parent reply other threads:[~2018-05-04 4:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 10:56 [PATCH] staging: wilc1000: allocate less memory Dan Carpenter
2018-05-04 4:56 ` Ajay Singh [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180504101408.261450a5@ajaysk-VirtualBox \
--to=ajay.kathat@microchip.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox