Re: [PATCH v2] media: davinci vpbe: array underflow in vpbe_enum_outputs()

Dan Carpenter
2018-05-25T13:21:57Z

On Fri, May 25, 2018 at 03:16:21PM +0200, Hans Verkuil wrote:
> On 25/05/18 15:12, Dan Carpenter wrote:
> > In vpbe_enum_outputs() we check if (temp_index >= cfg->num_outputs) but
> > the problem is that temp_index can be negative. I've made
> > cgf->num_outputs unsigned to fix this issue.
>
> Shouldn't temp_index also be made unsigned? It certainly would make a lot of
> sense to do that.

Yeah, sure. It doesn't make any difference in terms of runtime but it's
probably cleaner.

regards,
dan carpenter