From: Leon Romanovsky <leon@kernel.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] IB/mlx5: Fix return value check in flow_counters_set_data()
Date: Thu, 07 Jun 2018 05:56:27 +0000 [thread overview]
Message-ID: <20180607055627.GA2958@mtr-leonro.mtl.com> (raw)
In-Reply-To: <1528336061-13069-1-git-send-email-weiyongjun1@huawei.com>
[-- Attachment #1: Type: text/plain, Size: 577 bytes --]
On Thu, Jun 07, 2018 at 01:47:41AM +0000, Wei Yongjun wrote:
> In case of error, the function mlx5_fc_create() returns ERR_PTR() and
> never returns NULL. The NULL test in the return value check should be
> replaced with IS_ERR().
>
> Fixes: 3b3233fbf02e ("IB/mlx5: Add flow counters binding support")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/infiniband/hw/mlx5/main.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Thanks a lot, I thought that I fixed it prior submission, anyway.
Acked-by: Leon Romanovsky <leonro@mellanox.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
next prev parent reply other threads:[~2018-06-07 5:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-07 1:47 [PATCH -next] IB/mlx5: Fix return value check in flow_counters_set_data() Wei Yongjun
2018-06-07 5:56 ` Leon Romanovsky [this message]
2018-06-08 23:13 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180607055627.GA2958@mtr-leonro.mtl.com \
--to=leon@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox