From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Date: Thu, 07 Jun 2018 13:25:34 +0000
Subject: Re: [PATCH] typec: tcpm: Fix a msecs vs jiffies bug
Message-Id: <20180607132534.GD17155@kuha.fi.intel.com>
List-Id: <kernel-janitors.vger.kernel.org>
References: <20180607131714.hjpd7xdhcpzntkob@kili.mountain>
In-Reply-To: <20180607131714.hjpd7xdhcpzntkob@kili.mountain>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Guenter Roeck <groeck@chromium.org>, Greg Kroah-Hartman <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org

On Thu, Jun 07, 2018 at 04:17:14PM +0300, Dan Carpenter wrote:
> The tcpm_set_state() function take msecs not jiffies.
> 
> Fixes: f0690a25a140 ("staging: typec: USB Type-C Port Manager (tcpm)")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Acked-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>

> diff --git a/drivers/usb/typec/tcpm.c b/drivers/usb/typec/tcpm.c
> index 8a201dd53d36..0dfd755020f4 100644
> --- a/drivers/usb/typec/tcpm.c
> +++ b/drivers/usb/typec/tcpm.c
> @@ -3043,7 +3043,8 @@ static void run_state_machine(struct tcpm_port *port)
>  		    tcpm_port_is_sink(port) &&
>  		    time_is_after_jiffies(port->delayed_runtime)) {
>  			tcpm_set_state(port, SNK_DISCOVERY,
> -				       port->delayed_runtime - jiffies);
> +				       jiffies_to_msecs(port->delayed_runtime -
> +							jiffies));
>  			break;
>  		}
>  		tcpm_set_state(port, unattached_state(port), 0);

-- 
heikki