* [PATCH -next] ata: ahci_mvebu: ahci_mvebu_stop_engine() can be static
@ 2018-06-06 6:56 Wei Yongjun
2018-06-18 18:31 ` Tejun Heo
0 siblings, 1 reply; 2+ messages in thread
From: Wei Yongjun @ 2018-06-06 6:56 UTC (permalink / raw)
To: kernel-janitors
Fixes the following sparse warning:
drivers/ata/ahci_mvebu.c:85:5: warning:
symbol 'ahci_mvebu_stop_engine' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/ata/ahci_mvebu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/ata/ahci_mvebu.c b/drivers/ata/ahci_mvebu.c
index 0045dac..72d90b4 100644
--- a/drivers/ata/ahci_mvebu.c
+++ b/drivers/ata/ahci_mvebu.c
@@ -82,7 +82,7 @@ static void ahci_mvebu_regret_option(struct ahci_host_priv *hpriv)
*
* Return: 0 on success; Error code otherwise.
*/
-int ahci_mvebu_stop_engine(struct ata_port *ap)
+static int ahci_mvebu_stop_engine(struct ata_port *ap)
{
void __iomem *port_mmio = ahci_port_base(ap);
u32 tmp, port_fbs;
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH -next] ata: ahci_mvebu: ahci_mvebu_stop_engine() can be static
2018-06-06 6:56 [PATCH -next] ata: ahci_mvebu: ahci_mvebu_stop_engine() can be static Wei Yongjun
@ 2018-06-18 18:31 ` Tejun Heo
0 siblings, 0 replies; 2+ messages in thread
From: Tejun Heo @ 2018-06-18 18:31 UTC (permalink / raw)
To: kernel-janitors
On Wed, Jun 06, 2018 at 06:56:34AM +0000, Wei Yongjun wrote:
> Fixes the following sparse warning:
>
> drivers/ata/ahci_mvebu.c:85:5: warning:
> symbol 'ahci_mvebu_stop_engine' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Applied to libata/for-4.18-fixes.
Thanks.
--
tejun
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-06-18 18:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-06-06 6:56 [PATCH -next] ata: ahci_mvebu: ahci_mvebu_stop_engine() can be static Wei Yongjun
2018-06-18 18:31 ` Tejun Heo
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).