Re: [PATCH] IB/core: type promotion bug in rdma_rw_init_one_mr()

Dan Carpenter
2018-07-04T17:01:57Z

On Wed, Jul 04, 2018 at 08:49:47AM -0600, Jason Gunthorpe wrote:
> On Wed, Jul 04, 2018 at 12:55:41PM +0200, Håkon Bugge wrote:
> > Is:
> >
> > if (ret < (int)nents) {
> >
> > a more intuitive fix?
>
> That could lead to truncation/force negativeness of nents :(
>

In this case, if nents is over INT_MAX we're already toasted.

> I wonder how many bugs like this we have.

This is a static checker fix, so Julia fixed 3 and I fixed 6...

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html