* [PATCH] drm/vkms: off by one in vkms_gem_fault()
@ 2018-07-14 11:04 Dan Carpenter
2018-07-16 11:26 ` Rodrigo Siqueira
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2018-07-14 11:04 UTC (permalink / raw)
To: David Airlie; +Cc: Daniel Vetter, kernel-janitors, dri-devel, Rodrigo Siqueira
The > should be >= so that we don't read one page beyond the end of the
obj->pages[] array.
Fixes: 559e50fd34d1 ("drm/vkms: Add dumb operations")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/gpu/drm/vkms/vkms_gem.c b/drivers/gpu/drm/vkms/vkms_gem.c
index c7e38368602b..2cca8c2f260f 100644
--- a/drivers/gpu/drm/vkms/vkms_gem.c
+++ b/drivers/gpu/drm/vkms/vkms_gem.c
@@ -55,7 +55,7 @@ int vkms_gem_fault(struct vm_fault *vmf)
page_offset = (vaddr - vma->vm_start) >> PAGE_SHIFT;
num_pages = DIV_ROUND_UP(obj->gem.size, PAGE_SIZE);
- if (page_offset > num_pages)
+ if (page_offset >= num_pages)
return VM_FAULT_SIGBUS;
ret = -ENOENT;
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] drm/vkms: off by one in vkms_gem_fault()
2018-07-14 11:04 [PATCH] drm/vkms: off by one in vkms_gem_fault() Dan Carpenter
@ 2018-07-16 11:26 ` Rodrigo Siqueira
0 siblings, 0 replies; 2+ messages in thread
From: Rodrigo Siqueira @ 2018-07-16 11:26 UTC (permalink / raw)
To: Dan Carpenter; +Cc: David Airlie, Daniel Vetter, kernel-janitors, dri-devel
Hi Dan,
Thanks for your patch. I checked and tested it, everything is fine.
On 07/14, Dan Carpenter wrote:
> The > should be >= so that we don't read one page beyond the end of the
> obj->pages[] array.
>
> Fixes: 559e50fd34d1 ("drm/vkms: Add dumb operations")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/gpu/drm/vkms/vkms_gem.c b/drivers/gpu/drm/vkms/vkms_gem.c
> index c7e38368602b..2cca8c2f260f 100644
> --- a/drivers/gpu/drm/vkms/vkms_gem.c
> +++ b/drivers/gpu/drm/vkms/vkms_gem.c
> @@ -55,7 +55,7 @@ int vkms_gem_fault(struct vm_fault *vmf)
> page_offset = (vaddr - vma->vm_start) >> PAGE_SHIFT;
> num_pages = DIV_ROUND_UP(obj->gem.size, PAGE_SIZE);
>
> - if (page_offset > num_pages)
> + if (page_offset >= num_pages)
> return VM_FAULT_SIGBUS;
>
> ret = -ENOENT;
Reviewed-by: Rodrigo Siqueira <rodrigosiqueiramelo@gmail.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-07-16 11:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-14 11:04 [PATCH] drm/vkms: off by one in vkms_gem_fault() Dan Carpenter
2018-07-16 11:26 ` Rodrigo Siqueira
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox