From: Yuval Shaia <yuval.shaia@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] IB/ipoib: Fix error return code in ipoib_dev_init()
Date: Mon, 16 Jul 2018 20:25:21 +0000 [thread overview]
Message-ID: <20180716202520.GB3208@lap1> (raw)
In-Reply-To: <1531314942-178931-1-git-send-email-weiyongjun1@huawei.com>
On Wed, Jul 11, 2018 at 01:15:42PM +0000, Wei Yongjun wrote:
> Fix to return a negative error code from the ipoib_neigh_hash_init()
> error handling case instead of 0, as done elsewhere in this function.
>
> Fixes: 515ed4f3aab4 ("IB/IPoIB: Separate control and data related initializations")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
> drivers/infiniband/ulp/ipoib/ipoib_main.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> index 9bcd487..d11adfa 100644
> --- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
> +++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
> @@ -1791,7 +1791,8 @@ int ipoib_dev_init(struct net_device *dev, struct ib_device *ca, int port)
> goto out_free_pd;
> }
>
> - if (ipoib_neigh_hash_init(priv) < 0) {
> + ret = ipoib_neigh_hash_init(priv);
> + if (ret < 0) {
> pr_warn("%s failed to init neigh hash\n", dev->name);
> goto out_dev_uninit;
> }
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
>
next prev parent reply other threads:[~2018-07-16 20:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-11 13:15 [PATCH -next] IB/ipoib: Fix error return code in ipoib_dev_init() Wei Yongjun
2018-07-16 20:25 ` Yuval Shaia [this message]
2018-07-24 20:57 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180716202520.GB3208@lap1 \
--to=yuval.shaia@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox