From: Miquel Raynal <miquel.raynal@bootlin.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] thermal: armada: fix return value check in armada_thermal_probe_legacy()
Date: Mon, 30 Jul 2018 07:35:47 +0000 [thread overview]
Message-ID: <20180730093547.5ddbdf55@xps13> (raw)
In-Reply-To: <1532918524-46054-1-git-send-email-weiyongjun1@huawei.com>
Hi Daniel,
Daniel Lezcano <daniel.lezcano@linaro.org> wrote on Mon, 30 Jul 2018
08:18:53 +0200:
> On 30/07/2018 04:42, Wei Yongjun wrote:
> > In case of error, the function platform_get_resource() returns NULL
> > pointer not ERR_PTR(). The IS_ERR() test in the return value check
> > should be replaced with NULL test.
> >
> > Fixes: 175637792d45 ("thermal: armada: convert driver to syscon register accesses")
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> > ---
>
> Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
>
>
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
prev parent reply other threads:[~2018-07-30 7:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-30 2:42 [PATCH -next] thermal: armada: fix return value check in armada_thermal_probe_legacy() Wei Yongjun
2018-07-30 6:18 ` Daniel Lezcano
2018-07-30 7:35 ` Miquel Raynal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180730093547.5ddbdf55@xps13 \
--to=miquel.raynal@bootlin.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox