[PATCH -next] thermal: armada: fix return value check in armada_thermal_probe_legacy()

[PATCH -next] thermal: armada: fix return value check in armada_thermal_probe_legacy()

[Wei Yongjun]

In case of error, the function platform_get_resource() returns NULL
pointer not ERR_PTR(). The IS_ERR() test in the return value check
should be replaced with NULL test.

Fixes: 175637792d45 ("thermal: armada: convert driver to syscon register accesses")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/thermal/armada_thermal.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
index 8de4ba5..6782814 100644
--- a/drivers/thermal/armada_thermal.c
+++ b/drivers/thermal/armada_thermal.c
@@ -526,8 +526,8 @@ static int armada_thermal_probe_legacy(struct platform_device *pdev,
 
 	/* First memory region points towards the status register */
 	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
-	if (IS_ERR(res))
-		return PTR_ERR(res);
+	if (!res)
+		return -EINVAL;
 
 	/*
 	 * Edit the resource start address and length to map over all the

Re: [PATCH -next] thermal: armada: fix return value check in armada_thermal_probe_legacy()

[Daniel Lezcano]

On 30/07/2018 04:42, Wei Yongjun wrote:
> In case of error, the function platform_get_resource() returns NULL
> pointer not ERR_PTR(). The IS_ERR() test in the return value check
> should be replaced with NULL test.
> 
> Fixes: 175637792d45 ("thermal: armada: convert driver to syscon register accesses")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---

Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>


-- 
 <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe kernel-janitors" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH -next] thermal: armada: fix return value check in armada_thermal_probe_legacy()

[Miquel Raynal]

Hi Daniel,

Daniel Lezcano <daniel.lezcano@linaro.org> wrote on Mon, 30 Jul 2018
08:18:53 +0200:

> On 30/07/2018 04:42, Wei Yongjun wrote:
> > In case of error, the function platform_get_resource() returns NULL
> > pointer not ERR_PTR(). The IS_ERR() test in the return value check
> > should be replaced with NULL test.
> > 
> > Fixes: 175637792d45 ("thermal: armada: convert driver to syscon register accesses")
> > Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> > ---  
> 
> Reviewed-by: Daniel Lezcano <daniel.lezcano@linaro.org>
> 
> 

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>