public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] x86/uv: remove redundant check of p == q
Date: Tue, 31 Jul 2018 05:56:01 +0000	[thread overview]
Message-ID: <20180731055601.GA18964@gmail.com> (raw)
In-Reply-To: <20180730103117.13731-1-colin.king@canonical.com>


* Colin King <colin.king@canonical.com> wrote:

> From: Colin Ian King <colin.king@canonical.com>
> 
> The check for p = q is dead code because the proceeding switch
> statements jump to the end of the outer for-loop with continue
> statements.  Remove the dead code.
> 
> Detected by CoverityScan, CID#145071 ("Structureally dead code")

Do they really spell it "structureally", or is that your typo?

Also, pease Cc: x86 patches to lkml.

Thanks,

	Ingo

      reply	other threads:[~2018-07-31  5:56 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-07-30 10:31 [PATCH] x86/uv: remove redundant check of p == q Colin King
2018-07-31  5:56 ` Ingo Molnar [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180731055601.GA18964@gmail.com \
    --to=mingo@kernel.org \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox