Re: [PATCH] fpga: dfl: fme: error pointer vs NULL bug

Wu Hao
2018-08-02T08:40:42Z

On Thu, Aug 02, 2018 at 11:29:31AM +0300, Dan Carpenter wrote:
> The dfl_fme_create_region() function doesn't return NULL pointers, it
> returns error pointers.

Thanks for your patch. But it's the same fixing as below one. :)

https://marc.info/?l=linux-fpga&m\x153200573532534&w=2

Hao

>
> Fixes: 29de76240e86 ("fpga: dfl: fme: add partial reconfiguration sub feature support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/fpga/dfl-fme-pr.c b/drivers/fpga/dfl-fme-pr.c
> index fc9fd2d0482f..0b840531ef33 100644
> --- a/drivers/fpga/dfl-fme-pr.c
> +++ b/drivers/fpga/dfl-fme-pr.c
> @@ -420,7 +420,7 @@ static int pr_mgmt_init(struct platform_device *pdev,
> /* Create region for each port */
> fme_region = dfl_fme_create_region(pdata, mgr,
> fme_br->br, i);
> - if (!fme_region) {
> + if (IS_ERR(fme_region)) {
> ret = PTR_ERR(fme_region);
> goto destroy_region;
> }
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fpga" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html