From: Jason Gunthorpe <jgg@ziepe.ca>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] rdma/cxgb4: fix some info leaks
Date: Fri, 03 Aug 2018 02:17:53 +0000 [thread overview]
Message-ID: <20180803021753.GA16533@ziepe.ca> (raw)
In-Reply-To: <20180802075613.4zu6m6rv2dcumr5l@kili.mountain>
On Thu, Aug 02, 2018 at 10:56:13AM +0300, Dan Carpenter wrote:
> In c4iw_create_qp() there are several struct members which potentially
> aren't inintialized like uresp.rq_key. I've fixed this code before in
> in commit ae1fe07f3f42 ("RDMA/cxgb4: Fix stack info leak in
> c4iw_create_qp()") so this time I'm just going to take a big hammer
> approach and memset the whole struct to zero. Hopefully, it will stay
> fixed this time.
>
> In c4iw_create_srq() we don't clear uresp.reserved.
>
> Fixes: 6a0b6174d35a ("rdma/cxgb4: Add support for kernel mode SRQ's")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> Acked-by: Raju Rangoju <rajur@chelsio.com>
> ---
> These bugs are detected with Smatch btw if you want to go back to fixing
> them yourselves in a more delicate way.
Applied to for-next, thanks
Jason
prev parent reply other threads:[~2018-08-03 2:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-02 7:56 [PATCH] rdma/cxgb4: fix some info leaks Dan Carpenter
2018-08-02 12:23 ` Raju Rangoju
2018-08-03 2:17 ` Jason Gunthorpe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180803021753.GA16533@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox