* [PATCH] drm/i915/gvt: Off by one in intel_vgpu_write_fence() [not found] <20180807023944.GZ22630@zhen-hp.sh.intel.com> @ 2018-08-07 6:46 ` Dan Carpenter 2018-08-07 14:26 ` Rodrigo Vivi 0 siblings, 1 reply; 2+ messages in thread From: Dan Carpenter @ 2018-08-07 6:46 UTC (permalink / raw) To: Zhenyu Wang, Zhi Wang Cc: David Airlie, intel-gfx, kernel-janitors, Rodrigo Vivi, intel-gvt-dev The > should be >= here so that we don't read one element beyond the end of the array. Fixes: 28a60dee2ce6 ("drm/i915/gvt: vGPU HW resource management") Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> diff --git a/drivers/gpu/drm/i915/gvt/aperture_gm.c b/drivers/gpu/drm/i915/gvt/aperture_gm.c index 380eeb2a0e83..fe754022e356 100644 --- a/drivers/gpu/drm/i915/gvt/aperture_gm.c +++ b/drivers/gpu/drm/i915/gvt/aperture_gm.c @@ -131,7 +131,7 @@ void intel_vgpu_write_fence(struct intel_vgpu *vgpu, assert_rpm_wakelock_held(dev_priv); - if (WARN_ON(fence > vgpu_fence_sz(vgpu))) + if (WARN_ON(fence >= vgpu_fence_sz(vgpu))) return; reg = vgpu->fence.regs[fence]; ^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] drm/i915/gvt: Off by one in intel_vgpu_write_fence() 2018-08-07 6:46 ` [PATCH] drm/i915/gvt: Off by one in intel_vgpu_write_fence() Dan Carpenter @ 2018-08-07 14:26 ` Rodrigo Vivi 0 siblings, 0 replies; 2+ messages in thread From: Rodrigo Vivi @ 2018-08-07 14:26 UTC (permalink / raw) To: Dan Carpenter; +Cc: David Airlie, intel-gfx, kernel-janitors, intel-gvt-dev On Tue, Aug 07, 2018 at 09:46:02AM +0300, Dan Carpenter wrote: > The > should be >= here so that we don't read one element beyond the > end of the array. > > Fixes: 28a60dee2ce6 ("drm/i915/gvt: vGPU HW resource management") > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> > > diff --git a/drivers/gpu/drm/i915/gvt/aperture_gm.c b/drivers/gpu/drm/i915/gvt/aperture_gm.c > index 380eeb2a0e83..fe754022e356 100644 > --- a/drivers/gpu/drm/i915/gvt/aperture_gm.c > +++ b/drivers/gpu/drm/i915/gvt/aperture_gm.c > @@ -131,7 +131,7 @@ void intel_vgpu_write_fence(struct intel_vgpu *vgpu, > > assert_rpm_wakelock_held(dev_priv); > > - if (WARN_ON(fence > vgpu_fence_sz(vgpu))) > + if (WARN_ON(fence >= vgpu_fence_sz(vgpu))) > return; > > reg = vgpu->fence.regs[fence]; ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-07 14:26 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20180807023944.GZ22630@zhen-hp.sh.intel.com>
2018-08-07 6:46 ` [PATCH] drm/i915/gvt: Off by one in intel_vgpu_write_fence() Dan Carpenter
2018-08-07 14:26 ` Rodrigo Vivi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox