public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] thermal: armada: fix a test in probe()
Date: Wed, 19 Sep 2018 11:35:22 +0000	[thread overview]
Message-ID: <20180919133522.7b0393c6@xps13> (raw)
In-Reply-To: <20180919103500.GB9238@mwanda>

Hi Dan,

Dan Carpenter <dan.carpenter@oracle.com> wrote on Wed, 19 Sep 2018
13:35:00 +0300:

> The platform_get_resource() function doesn't return error pointers, it
> returns NULL on error.
> 
> Fixes: 3d4e51844a4e ("thermal: armada: convert driver to syscon register accesses")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> 
> diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
> index 2c2f6d93034e..92f67d40f2e9 100644
> --- a/drivers/thermal/armada_thermal.c
> +++ b/drivers/thermal/armada_thermal.c
> @@ -526,8 +526,8 @@ static int armada_thermal_probe_legacy(struct platform_device *pdev,
>  
>  	/* First memory region points towards the status register */
>  	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	if (IS_ERR(res))
> -		return PTR_ERR(res);
> +	if (!res)
> +		return -EIO;
>  
>  	/*
>  	 * Edit the resource start address and length to map over all the

Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>

Thanks,
Miquèl

      reply	other threads:[~2018-09-19 11:35 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-19 10:35 [PATCH] thermal: armada: fix a test in probe() Dan Carpenter
2018-09-19 11:35 ` Miquel Raynal [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180919133522.7b0393c6@xps13 \
    --to=miquel.raynal@bootlin.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox