* [PATCH] thermal: armada: fix a test in probe()
@ 2018-09-19 10:35 Dan Carpenter
2018-09-19 11:35 ` Miquel Raynal
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2018-09-19 10:35 UTC (permalink / raw)
To: kernel-janitors
The platform_get_resource() function doesn't return error pointers, it
returns NULL on error.
Fixes: 3d4e51844a4e ("thermal: armada: convert driver to syscon register accesses")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
index 2c2f6d93034e..92f67d40f2e9 100644
--- a/drivers/thermal/armada_thermal.c
+++ b/drivers/thermal/armada_thermal.c
@@ -526,8 +526,8 @@ static int armada_thermal_probe_legacy(struct platform_device *pdev,
/* First memory region points towards the status register */
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
- if (IS_ERR(res))
- return PTR_ERR(res);
+ if (!res)
+ return -EIO;
/*
* Edit the resource start address and length to map over all the
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] thermal: armada: fix a test in probe()
2018-09-19 10:35 [PATCH] thermal: armada: fix a test in probe() Dan Carpenter
@ 2018-09-19 11:35 ` Miquel Raynal
0 siblings, 0 replies; 2+ messages in thread
From: Miquel Raynal @ 2018-09-19 11:35 UTC (permalink / raw)
To: kernel-janitors
Hi Dan,
Dan Carpenter <dan.carpenter@oracle.com> wrote on Wed, 19 Sep 2018
13:35:00 +0300:
> The platform_get_resource() function doesn't return error pointers, it
> returns NULL on error.
>
> Fixes: 3d4e51844a4e ("thermal: armada: convert driver to syscon register accesses")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/thermal/armada_thermal.c b/drivers/thermal/armada_thermal.c
> index 2c2f6d93034e..92f67d40f2e9 100644
> --- a/drivers/thermal/armada_thermal.c
> +++ b/drivers/thermal/armada_thermal.c
> @@ -526,8 +526,8 @@ static int armada_thermal_probe_legacy(struct platform_device *pdev,
>
> /* First memory region points towards the status register */
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (IS_ERR(res))
> - return PTR_ERR(res);
> + if (!res)
> + return -EIO;
>
> /*
> * Edit the resource start address and length to map over all the
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-09-19 11:35 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-09-19 10:35 [PATCH] thermal: armada: fix a test in probe() Dan Carpenter
2018-09-19 11:35 ` Miquel Raynal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox