public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Daniel Drake <drake@endlessm.com>, Joe Perches <joe@perches.com>,
	Alan Stern <stern@rowland.harvard.edu>,
	Mathias Nyman <mathias.nyman@linux.intel.com>,
	Felipe Balbi <felipe.balbi@linux.intel.com>,
	Martin Liu <liumartin@google.com>,
	linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] USB: core: remove set but not used variable 'udev'
Date: Fri, 28 Sep 2018 13:10:00 +0000	[thread overview]
Message-ID: <20180928131000.GA15118@kroah.com> (raw)
In-Reply-To: <1537597886-136734-1-git-send-email-yuehaibing@huawei.com>

On Sat, Sep 22, 2018 at 06:31:26AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> drivers/usb/core/driver.c: In function 'usb_driver_claim_interface':
> drivers/usb/core/driver.c:513:21: warning:
>  variable 'udev' set but not used [-Wunused-but-set-variable]
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>
> ---
>  drivers/usb/core/driver.c | 3 ---
>  1 file changed, 3 deletions(-)

This patch breaks the build, which is not ok :(

  parent reply	other threads:[~2018-09-28 13:10 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-22  6:31 [PATCH -next] USB: core: remove set but not used variable 'udev' YueHaibing
2018-09-24 14:10 ` Alan Stern
2018-09-28 13:10 ` Greg Kroah-Hartman [this message]
2018-09-28 20:35 ` Alan Stern

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180928131000.GA15118@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=drake@endlessm.com \
    --cc=felipe.balbi@linux.intel.com \
    --cc=joe@perches.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=liumartin@google.com \
    --cc=mathias.nyman@linux.intel.com \
    --cc=stern@rowland.harvard.edu \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox