From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] jump_label: Annotate entries that operate on __init code earlier
Date: Mon, 01 Oct 2018 06:56:36 +0000 [thread overview]
Message-ID: <20181001065636.GA22197@mwanda> (raw)
Hello Ard Biesheuvel,
This is a semi-automatic email about new static checker warnings.
The patch 19483677684b: "jump_label: Annotate entries that operate on
__init code earlier" from Sep 18, 2018, leads to the following Smatch
complaint:
kernel/jump_label.c:524 __jump_label_mod_update()
error: we previously assumed 'm' could be null (see line 519)
kernel/jump_label.c
518 m = mod->mod;
519 if (!m)
^^
Old code has check for NULL
520 stop = __stop___jump_table;
521 else
522 stop = m->jump_entries + m->num_jump_entries;
523 __jump_label_update(key, mod->entries, stop,
524 m->state = MODULE_STATE_COMING);
^^^^^^^^
New code adds unchecked dereference.
525 }
526 }
regards,
dan carpenter
reply other threads:[~2018-10-01 6:56 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181001065636.GA22197@mwanda \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox