kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [bug report] jump_label: Annotate entries that operate on __init code earlier
@ 2018-10-01  6:56 Dan Carpenter
  0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2018-10-01  6:56 UTC (permalink / raw)
  To: kernel-janitors

Hello Ard Biesheuvel,

This is a semi-automatic email about new static checker warnings.

The patch 19483677684b: "jump_label: Annotate entries that operate on 
__init code earlier" from Sep 18, 2018, leads to the following Smatch 
complaint:

    kernel/jump_label.c:524 __jump_label_mod_update()
    error: we previously assumed 'm' could be null (see line 519)

kernel/jump_label.c
   518			m = mod->mod;
   519			if (!m)
                            ^^
Old code has check for NULL

   520				stop = __stop___jump_table;
   521			else
   522				stop = m->jump_entries + m->num_jump_entries;
   523			__jump_label_update(key, mod->entries, stop,
   524					    m->state = MODULE_STATE_COMING);
                                            ^^^^^^^^
New code adds unchecked dereference.

   525		}
   526	}

regards,
dan carpenter

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2018-10-01  6:56 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-10-01  6:56 [bug report] jump_label: Annotate entries that operate on __init code earlier Dan Carpenter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).