From: Sinclair Yeh <syeh@vmware.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: Thomas Hellstrom <thellstrom@vmware.com>,
David Airlie <airlied@linux.ie>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
linux-graphics-maintainer <linux-graphics-maintainer@vmware.com>
Subject: Re: [PATCH -next] drm/vmwgfx: Remove set but not used variable 'file_priv'
Date: Fri, 05 Oct 2018 22:01:00 +0000 [thread overview]
Message-ID: <20181005215658.GA616@vmware.com> (raw)
In-Reply-To: <1538739418-151469-1-git-send-email-yuehaibing@huawei.com>
Reviewed-by: Sinclair Yeh <syeh@vmware.com>
On Fri, Oct 05, 2018 at 11:36:58AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/vmwgfx/vmwgfx_fence.c: In function 'vmw_event_fence_action_seq_passed':
> drivers/gpu/drm/vmwgfx/vmwgfx_fence.c:909:19: warning:
> variable 'file_priv' set but not used [-Wunused-but-set-variable]
> struct drm_file *file_priv;
>
> It not used any more since
> commit fb740cf2492c ("drm: Create drm_send_event helpers")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/gpu/drm/vmwgfx/vmwgfx_fence.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> index f872615..301260e 100644
> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_fence.c
> @@ -906,13 +906,10 @@ static void vmw_event_fence_action_seq_passed(struct vmw_fence_action *action)
> container_of(action, struct vmw_event_fence_action, action);
> struct drm_device *dev = eaction->dev;
> struct drm_pending_event *event = eaction->event;
> - struct drm_file *file_priv;
> -
>
> if (unlikely(event == NULL))
> return;
>
> - file_priv = event->file_priv;
> spin_lock_irq(&dev->event_lock);
>
> if (likely(eaction->tv_sec != NULL)) {
>
>
>
next prev parent reply other threads:[~2018-10-05 22:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-05 11:36 [PATCH -next] drm/vmwgfx: Remove set but not used variable 'file_priv' YueHaibing
2018-10-05 22:01 ` Sinclair Yeh [this message]
2019-02-14 1:54 ` [PATCH -next] drm/vmwgfx: Remove set but not used variable 'restart' YueHaibing
2019-02-14 19:58 ` Deepak Singh Rawat
2019-03-23 2:46 ` [PATCH -next] drm/vmwgfx: Remove set but not used variable 'fb_offset, fb_depth' YueHaibing
2019-03-25 17:26 ` Deepak Singh Rawat
2019-03-27 14:11 ` Mukesh Ojha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181005215658.GA616@vmware.com \
--to=syeh@vmware.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-graphics-maintainer@vmware.com \
--cc=linux-kernel@vger.kernel.org \
--cc=thellstrom@vmware.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).