From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Sat, 13 Oct 2018 17:29:12 +0000 Subject: Re: [PATCH] wil6210: fix debugfs_simple_attr.cocci warnings Message-Id: <20181013172912.2923960116@smtp.codeaurora.org> List-Id: References: <1538737646-118337-1-git-send-email-yuehaibing@huawei.com> In-Reply-To: <1538737646-118337-1-git-send-email-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: YueHaibing Cc: Maya Erez , linux-wireless@vger.kernel.org, wil6210@qti.qualcomm.com, kernel-janitors@vger.kernel.org, netdev@vger.kernel.org YueHaibing wrote: > Use DEFINE_DEBUGFS_ATTRIBUTE rather than DEFINE_SIMPLE_ATTRIBUTE > for debugfs files. > > Semantic patch information: > Rationale: DEFINE_SIMPLE_ATTRIBUTE + debugfs_create_file() > imposes some significant overhead as compared to > DEFINE_DEBUGFS_ATTRIBUTE + debugfs_create_file_unsafe(). > > Generated by: scripts/coccinelle/api/debugfs/debugfs_simple_attr.cocci > > Signed-off-by: YueHaibing > Signed-off-by: Kalle Valo Patch applied to ath-next branch of ath.git, thanks. f9dca154a4e4 wil6210: fix debugfs_simple_attr.cocci warnings -- https://patchwork.kernel.org/patch/10627883/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches