From mboxrd@z Thu Jan 1 00:00:00 1970 From: Miquel Raynal Date: Sun, 14 Oct 2018 16:03:24 +0000 Subject: Re: [PATCH] irqchip/irq-mvebu-sei: Fix a NULL vs IS_ERR() bug in probe Message-Id: <20181014180324.56e7d8d5@xps13> List-Id: References: <20181013102246.GD16086@mwanda> In-Reply-To: <20181013102246.GD16086@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable To: linux-arm-kernel@lists.infradead.org Hi Dan, Dan Carpenter wrote on Sat, 13 Oct 2018 13:22:46 +0300: > The devm_ioremap_resource() function never returns NULL, it returns > error pointers. >=20 > Fixes: 61ce8d8d8a81 ("irqchip/irq-mvebu-sei: Add new driver for Marvell S= EI") > Signed-off-by: Dan Carpenter > --- > drivers/irqchip/irq-mvebu-sei.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) >=20 > diff --git a/drivers/irqchip/irq-mvebu-sei.c b/drivers/irqchip/irq-mvebu-= sei.c > index 566d69a2edbc..add4c9c934c8 100644 > --- a/drivers/irqchip/irq-mvebu-sei.c > +++ b/drivers/irqchip/irq-mvebu-sei.c > @@ -384,9 +384,9 @@ static int mvebu_sei_probe(struct platform_device *pd= ev) > =20 > sei->res =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); > sei->base =3D devm_ioremap_resource(sei->dev, sei->res); > - if (!sei->base) { > + if (IS_ERR(sei->base)) { > dev_err(sei->dev, "Failed to remap SEI resource\n"); > - return -ENODEV; > + return PTR_ERR(sei->base); > } > =20 > /* Retrieve the SEI capabilities with the interrupt ranges */ Reviewed-by: Miquel Raynal Thanks, Miqu=C3=A8l