From: Dan Carpenter <dan.carpenter@oracle.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Tony Luck <tony.luck@intel.com>,
Qiuxu Zhuo <qiuxu.zhuo@intel.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-edac@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] EDAC, skx: clean up a debug printk
Date: Tue, 27 Nov 2018 13:24:30 +0000 [thread overview]
Message-ID: <20181127131316.GA3073@unbuntlaptop> (raw)
In-Reply-To: <20181127113235.7mxd7cxojtzbkbid@kili.mountain>
On Tue, Nov 27, 2018 at 01:49:15PM +0100, Borislav Petkov wrote:
> On Tue, Nov 27, 2018 at 02:32:35PM +0300, Dan Carpenter wrote:
> > I've removed the 0x prefix for the row and col because the %#x format
> > already adds a 0x.
>
> Pls use passive tone in your commit message: no "we" or "I", etc.
>
> Also, pls read section "2) Describe your changes" in
> Documentation/process/submitting-patches.rst.
>
I don't agree with all the style nit-picking these days. I think a
competent programmer can understand the commit message so it's fine.
I'm not going to resend, sorry.
Just give me the Reported-by tag and re-write it how you want.
regards,
dan carpenter
next prev parent reply other threads:[~2018-11-27 13:24 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-27 11:32 [PATCH] EDAC, skx: clean up a debug printk Dan Carpenter
2018-11-27 12:49 ` Borislav Petkov
2018-11-27 13:24 ` Dan Carpenter [this message]
2018-11-27 13:27 ` Borislav Petkov
2018-11-27 13:31 ` Dan Carpenter
2018-11-27 13:53 ` Dan Carpenter
2018-11-27 14:01 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20181127131316.GA3073@unbuntlaptop \
--to=dan.carpenter@oracle.com \
--cc=bp@alien8.de \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=qiuxu.zhuo@intel.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox