From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 29 Nov 2018 14:21:13 +0000 Subject: Re: [PATCH] ath10k: remove an unnecessary NULL check Message-Id: <20181129142113.GU3073@unbuntlaptop> List-Id: References: <20181129103214.5tudci6izlfaasqx@kili.mountain> <87sgzk56w3.fsf@kamboji.qca.qualcomm.com> In-Reply-To: <87sgzk56w3.fsf@kamboji.qca.qualcomm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Kalle Valo Cc: linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org, Rakesh Pillai , ath10k@lists.infradead.org On Thu, Nov 29, 2018 at 03:51:24PM +0200, Kalle Valo wrote: > Dan Carpenter writes: > > > The "survey" pointer is the address of an array element. We know that > > it can't be NULL so this check can be removed. > > > > Signed-off-by: Dan Carpenter > > --- > > drivers/net/wireless/ath/ath10k/wmi.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/net/wireless/ath/ath10k/wmi.c b/drivers/net/wireless/ath/ath10k/wmi.c > > index 659513bf4ddc..6a04727b63ce 100644 > > --- a/drivers/net/wireless/ath/ath10k/wmi.c > > +++ b/drivers/net/wireless/ath/ath10k/wmi.c > > @@ -2578,7 +2578,7 @@ static void ath10k_wmi_event_chan_info_unpaired(struct ath10k *ar, > > > > survey = &ar->survey[idx]; > > > > - if (!params->mac_clk_mhz || !survey) > > + if (!params->mac_clk_mhz) > > return; > > Can you please CC linux-wireless so that patchwork sees this? > Sure. I can resend. regards, dan carpenter