Re: [PATCH -next] mmc: jz4740: Use PTR_ERR_OR_ZERO in jz4740_mmc_request_gpios()

Joey Pabalinas
2018-12-01T01:55:46Z

[-- Attachment #1: Type: text/plain, Size: 1133 bytes --]

On Sat, Dec 01, 2018 at 01:45:46AM +0000, YueHaibing wrote:
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Acked-by: Joey Pabalinas <joeypabalinas@gmail.com>

On Sat, Dec 01, 2018 at 01:45:46AM +0000, YueHaibing wrote:
> Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/mmc/host/jz4740_mmc.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/mmc/host/jz4740_mmc.c b/drivers/mmc/host/jz4740_mmc.c
> index 6f7a99e..8eca423 100644
> --- a/drivers/mmc/host/jz4740_mmc.c
> +++ b/drivers/mmc/host/jz4740_mmc.c
> @@ -975,10 +975,7 @@ static int jz4740_mmc_request_gpios(struct jz4740_mmc_host *host,
>
> host->power = devm_gpiod_get_optional(&pdev->dev, "power",
> GPIOD_OUT_HIGH);
> - if (IS_ERR(host->power))
> - return PTR_ERR(host->power);
> -
> - return 0;
> + return PTR_ERR_OR_ZERO(host->power);
> }
>
> static const struct of_device_id jz4740_mmc_of_match[] = {

--
Cheers,
Joey Pabalinas

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]