From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adeodato =?utf-8?B?U2ltw7M=?= Date: Thu, 17 Jan 2019 10:36:02 +0000 Subject: Re: [PATCH 1/3] mm: add include files so that function definitions have a prototype Message-Id: <20190117103602.GA6243@relativists.org> List-Id: References: <466ad4ebe5d788e7be6a14fbbcaaa9596bac7141.1543899764.git.dato@net.com.org.es> In-Reply-To: <466ad4ebe5d788e7be6a14fbbcaaa9596bac7141.1543899764.git.dato@net.com.org.es> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit To: linux-mm@kvack.org Cc: kernel-janitors@vger.kernel.org Hello, Any chance these three patches of mine (reviewed by Mike Rapoport) will get merged? Thanks for considering, -d P.S.: If they already got merged, I apologize—I couldn't find a repo for mm. (I checked master and next.) On Tue, Dec 4, 2018 at 02:14 -0300, Adeodato Simó wrote: > Previously, rodata_test(), usercopy_warn(), and usercopy_abort() were > defined without a matching prototype. Detected by -Wmissing-prototypes > GCC flag. > > Signed-off-by: Adeodato Simó > --- > I started poking at this after kernel-janitors got the suggestion[1] > to look into the -Wmissing-prototypes warnings. > > Thanks for considering! > > [1]: https://www.spinics.net/lists/linux-kernel-janitors/msg43981.html > > mm/rodata_test.c | 1 + > mm/usercopy.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/mm/rodata_test.c b/mm/rodata_test.c > index d908c8769b48..01306defbd1b 100644 > --- a/mm/rodata_test.c > +++ b/mm/rodata_test.c > @@ -11,6 +11,7 @@ > */ > #define pr_fmt(fmt) "rodata_test: " fmt > > +#include > #include > #include > > diff --git a/mm/usercopy.c b/mm/usercopy.c > index 852eb4e53f06..f487ba4888df 100644 > --- a/mm/usercopy.c > +++ b/mm/usercopy.c > @@ -20,6 +20,7 @@ > #include > #include > #include > +#include > #include > #include > #include > -- > 2.19.2 >