* [PATCH -next] gpio: tqmx86: Drop unnecessary gpiochip_remove in tqmx86_gpio_probe()
@ 2019-02-01 9:18 Wei Yongjun
2019-02-01 14:00 ` Andrew Lunn
2019-02-08 12:11 ` Linus Walleij
0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2019-02-01 9:18 UTC (permalink / raw)
To: kernel-janitors
It's not necessary to remove gpio_chip which added with
devm_gpiochip_add_data().
Fixes: b868db94a6a7 ("gpio: tqmx86: Add GPIO from for this IO controller")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/gpio/gpio-tqmx86.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpio/gpio-tqmx86.c b/drivers/gpio/gpio-tqmx86.c
index 6f7250c6f597..33dbe483f92f 100644
--- a/drivers/gpio/gpio-tqmx86.c
+++ b/drivers/gpio/gpio-tqmx86.c
@@ -291,7 +291,7 @@ static int tqmx86_gpio_probe(struct platform_device *pdev)
IRQ_TYPE_EDGE_BOTH);
if (ret) {
dev_err(dev, "Could not add irq chip\n");
- goto out_remove;
+ goto out_pm_dis;
}
gpiochip_set_chained_irqchip(chip, irq_chip,
@@ -309,8 +309,6 @@ static int tqmx86_gpio_probe(struct platform_device *pdev)
return 0;
-out_remove:
- gpiochip_remove(&gpio->chip);
out_pm_dis:
pm_runtime_disable(&pdev->dev);
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH -next] gpio: tqmx86: Drop unnecessary gpiochip_remove in tqmx86_gpio_probe()
2019-02-01 9:18 [PATCH -next] gpio: tqmx86: Drop unnecessary gpiochip_remove in tqmx86_gpio_probe() Wei Yongjun
@ 2019-02-01 14:00 ` Andrew Lunn
2019-02-08 12:11 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Lunn @ 2019-02-01 14:00 UTC (permalink / raw)
To: kernel-janitors
On Fri, Feb 01, 2019 at 09:18:41AM +0000, Wei Yongjun wrote:
> It's not necessary to remove gpio_chip which added with
> devm_gpiochip_add_data().
>
> Fixes: b868db94a6a7 ("gpio: tqmx86: Add GPIO from for this IO controller")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -next] gpio: tqmx86: Drop unnecessary gpiochip_remove in tqmx86_gpio_probe()
2019-02-01 9:18 [PATCH -next] gpio: tqmx86: Drop unnecessary gpiochip_remove in tqmx86_gpio_probe() Wei Yongjun
2019-02-01 14:00 ` Andrew Lunn
@ 2019-02-08 12:11 ` Linus Walleij
1 sibling, 0 replies; 3+ messages in thread
From: Linus Walleij @ 2019-02-08 12:11 UTC (permalink / raw)
To: kernel-janitors
On Fri, Feb 1, 2019 at 10:04 AM Wei Yongjun <weiyongjun1@huawei.com> wrote:
> It's not necessary to remove gpio_chip which added with
> devm_gpiochip_add_data().
>
> Fixes: b868db94a6a7 ("gpio: tqmx86: Add GPIO from for this IO controller")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Patch applied with Andew's review tag.
Yours,
Linus Walleij
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-02-08 12:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-01 9:18 [PATCH -next] gpio: tqmx86: Drop unnecessary gpiochip_remove in tqmx86_gpio_probe() Wei Yongjun
2019-02-01 14:00 ` Andrew Lunn
2019-02-08 12:11 ` Linus Walleij
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).