From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] Input: msm: Tweak an error message
Date: Sat, 09 Feb 2019 16:52:03 +0000 [thread overview]
Message-ID: <20190209165203.GA197782@dtor-ws> (raw)
In-Reply-To: <20190209090106.GB4865@kadam>
On Sat, Feb 09, 2019 at 12:01:06PM +0300, Dan Carpenter wrote:
> The PTR_ERR(NULL) value is zero and it's not useful to print that.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Applied, thank you.
> ---
> drivers/input/misc/msm-vibrator.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/input/misc/msm-vibrator.c b/drivers/input/misc/msm-vibrator.c
> index c06941021447..69f2579c4ec2 100644
> --- a/drivers/input/misc/msm-vibrator.c
> +++ b/drivers/input/misc/msm-vibrator.c
> @@ -199,8 +199,7 @@ static int msm_vibrator_probe(struct platform_device *pdev)
> vibrator->base = devm_ioremap(&pdev->dev, res->start,
> resource_size(res));
> if (!vibrator->base) {
> - dev_err(&pdev->dev, "Failed to iomap resource: %ld\n",
> - PTR_ERR(vibrator->base));
> + dev_err(&pdev->dev, "Failed to iomap resource.\n");
> return -ENOMEM;
> }
>
> --
> 2.17.1
>
--
Dmitry
prev parent reply other threads:[~2019-02-09 16:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-09 9:01 [PATCH] Input: msm: Tweak an error message Dan Carpenter
2019-02-09 16:52 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190209165203.GA197782@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox