Re: [f2fs-dev] [PATCH] f2fs: don't allow negative ->write_io_size_bits

Dan Carpenter
2019-02-13T09:46:15Z

On Wed, Feb 13, 2019 at 04:49:57PM +0800, Chao Yu wrote:
> On 2019/2/13 11:32, Chao Yu wrote:
> > On 2019/2/12 2:45, Dan Carpenter wrote:
> >> We put an upper bound on ->write_io_size_bits but we don't have a lower
> >> bound.
> >
> > Oh, lower bound, I think there are more cases didn't consider that,
> > let me check it.
>
> Sorry, one missing case:
>
> Shouldn't it be:
>
> if (arg <= 0 || arg > __ilog2_u32(BIO_MAX_PAGES)) {
> ^

It wouldn't be hard for me to redo my patch, but I don't know enough to
say if zero is invalid and I don't want to get blamed for that... Can
you do it, since you're better able to test the change?

So let's drop this patch, and then could you give me Reported-by credit
instead?

regards,
dan carpenter