From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 14 Feb 2019 05:54:57 +0000 Subject: Re: [PATCH] scsi: qla2xxx: remove redundant null check on pointer sess Message-Id: <20190214055457.GA2326@kadam> List-Id: References: <20190213135335.4790-1-colin.king@canonical.com> In-Reply-To: <20190213135335.4790-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: qla2xxx-upstream@qlogic.com, "James E . J . Bottomley" , "Martin K . Petersen" , linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, Feb 13, 2019 at 01:53:35PM +0000, Colin King wrote: > From: Colin Ian King > > The null check on pointer sess and the subsequent call is redundant > as sess is null on all the the paths that lead to the out_term2 label. > Hence the null check and the call can be removed. > > Detected by CoverityScan, CID#1420663 ("Logically dead code") > > Signed-off-by: Colin Ian King > --- > drivers/scsi/qla2xxx/qla_target.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/scsi/qla2xxx/qla_target.c b/drivers/scsi/qla2xxx/qla_target.c > index 6b8c655d9eb4..9af329a5ed90 100644 > --- a/drivers/scsi/qla2xxx/qla_target.c > +++ b/drivers/scsi/qla2xxx/qla_target.c > @@ -6396,8 +6396,6 @@ static void qlt_tmr_work(struct qla_tgt *tgt, > return; > > out_term2: > - if (sess) > - ha->tgt.tgt_ops->put_sess(sess); Several places do: sess = NULL; goto out_term2; We could remove the "sess = NULL;" because it's not required now. > spin_unlock_irqrestore(&ha->tgt.sess_lock, flags); > out_term: > qlt_send_term_exchange(ha->base_qpair, NULL, &prm->tm_iocb2, 1, 0); regards, dan carpenter