From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Fri, 15 Feb 2019 07:44:15 +0000 Subject: Re: [PATCH -next] scsi: lpfc: Remove set but not used variable 'phys_id' Message-Id: <20190215074415.GE2326@kadam> List-Id: References: <1536804299-64730-1-git-send-email-yuehaibing@huawei.com> In-Reply-To: <1536804299-64730-1-git-send-email-yuehaibing@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: kernel-janitors@vger.kernel.org Signed-off-by is like a legal document to say that you haven't added any proprietary SCO UNIXWARE code to the patch. You have sign every patch if you email it. Acked-by and Reviewed-by are less clear. Acked-by means you want it to be merged, I guess? I never use Acked by because I'm not a maintainer so it's not my place to approve things. regards, dan carpenter