public inbox for kernel-janitors@vger.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] tee: add supp_nowait flag in tee_context struct
Date: Tue, 19 Feb 2019 13:25:31 +0000	[thread overview]
Message-ID: <20190219132531.GA7458@kadam> (raw)

Hello Sumit Garg,

The patch 42bf4152d8a7: "tee: add supp_nowait flag in tee_context
struct" from Jan 29, 2019, leads to the following static checker
warning:

	drivers/tee/tee_core.c:996 tee_client_open_context()
	error: 'ctx' dereferencing possible ERR_PTR()

drivers/tee/tee_core.c
    986 	} while (IS_ERR(ctx) && PTR_ERR(ctx) != -ENOMEM);
                                        ^^^^^^^^^^^^^^^^^^^^^^^^
ctx can be ERR_PTR(-ENOMEM);

    987 
    988 	put_device(put_dev);
    989 	/*
    990 	 * Default behaviour for in kernel client is to not wait for
    991 	 * tee-supplicant if not present for any requests in this context.
    992 	 * Also this flag could be configured again before call to
    993 	 * tee_client_open_session() if any in kernel client requires
    994 	 * different behaviour.
    995 	 */
--> 996 	ctx->supp_nowait = true;
                ^^^^^^^^^^^^^^^^
And it leads to an Oops here.

    997 	return ctx;
    998 }

regards,
dan carpenter

             reply	other threads:[~2019-02-19 13:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-19 13:25 Dan Carpenter [this message]
2019-02-20  6:20 ` [bug report] tee: add supp_nowait flag in tee_context struct Sumit Garg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190219132531.GA7458@kadam \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox