From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] Input: ti_am335x_tsc - remove set but not used variable 'tscadc_dev'
Date: Tue, 19 Feb 2019 18:59:28 +0000 [thread overview]
Message-ID: <20190219185928.GC210481@dtor-ws> (raw)
In-Reply-To: <20190218133103.93973-1-yuehaibing@huawei.com>
On Mon, Feb 18, 2019 at 01:31:03PM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/input/touchscreen/ti_am335x_tsc.c: In function 'titsc_suspend':
> drivers/input/touchscreen/ti_am335x_tsc.c:510:24: warning:
> variable 'tscadc_dev' set but not used [-Wunused-but-set-variable]
>
> drivers/input/touchscreen/ti_am335x_tsc.c: In function 'titsc_resume':
> drivers/input/touchscreen/ti_am335x_tsc.c:527:24: warning:
> variable 'tscadc_dev' set but not used [-Wunused-but-set-variable]
>
> It's not used any more after 333e07ec4b33 ("Input: ti_am335x_tsc: Mark TSC
> device as wakeup source")
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Applied, thank you.
> ---
> drivers/input/touchscreen/ti_am335x_tsc.c | 4 ----
> 1 file changed, 4 deletions(-)
>
> diff --git a/drivers/input/touchscreen/ti_am335x_tsc.c b/drivers/input/touchscreen/ti_am335x_tsc.c
> index 9e8684ab48f4..83e685557a19 100644
> --- a/drivers/input/touchscreen/ti_am335x_tsc.c
> +++ b/drivers/input/touchscreen/ti_am335x_tsc.c
> @@ -507,10 +507,8 @@ static int titsc_remove(struct platform_device *pdev)
> static int __maybe_unused titsc_suspend(struct device *dev)
> {
> struct titsc *ts_dev = dev_get_drvdata(dev);
> - struct ti_tscadc_dev *tscadc_dev;
> unsigned int idle;
>
> - tscadc_dev = ti_tscadc_dev_get(to_platform_device(dev));
> if (device_may_wakeup(dev)) {
> titsc_writel(ts_dev, REG_IRQSTATUS, TSC_IRQENB_MASK);
> idle = titsc_readl(ts_dev, REG_IRQENABLE);
> @@ -524,9 +522,7 @@ static int __maybe_unused titsc_suspend(struct device *dev)
> static int __maybe_unused titsc_resume(struct device *dev)
> {
> struct titsc *ts_dev = dev_get_drvdata(dev);
> - struct ti_tscadc_dev *tscadc_dev;
>
> - tscadc_dev = ti_tscadc_dev_get(to_platform_device(dev));
> if (device_may_wakeup(dev)) {
> titsc_writel(ts_dev, REG_IRQWAKEUP,
> 0x00);
>
>
>
--
Dmitry
prev parent reply other threads:[~2019-02-19 18:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-18 13:31 [PATCH -next] Input: ti_am335x_tsc - remove set but not used variable 'tscadc_dev' YueHaibing
2019-02-19 18:59 ` Dmitry Torokhov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190219185928.GC210481@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).