kernel-janitors.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH -next] iw_cxgb4: make function read_tcb() static
@ 2019-02-18  6:51 Wei Yongjun
  2019-02-18 11:24 ` Raju Rangoju
  2019-02-19 22:01 ` Jason Gunthorpe
  0 siblings, 2 replies; 3+ messages in thread
From: Wei Yongjun @ 2019-02-18  6:51 UTC (permalink / raw)
  To: kernel-janitors

Fixes the following sparse warning:

drivers/infiniband/hw/cxgb4/cm.c:658:6: warning:
 symbol 'read_tcb' was not declared. Should it be static?

Fixes: 11a27e2121a5 ("iw_cxgb4: complete the cached SRQ buffers")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
 drivers/infiniband/hw/cxgb4/cm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
index ae90b2932bd2..4d232bdf9e97 100644
--- a/drivers/infiniband/hw/cxgb4/cm.c
+++ b/drivers/infiniband/hw/cxgb4/cm.c
@@ -655,7 +655,7 @@ static int send_halfclose(struct c4iw_ep *ep)
 	return c4iw_l2t_send(&ep->com.dev->rdev, skb, ep->l2t);
 }
 
-void read_tcb(struct c4iw_ep *ep)
+static void read_tcb(struct c4iw_ep *ep)
 {
 	struct sk_buff *skb;
 	struct cpl_get_tcb *req;

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] iw_cxgb4: make function read_tcb() static
  2019-02-18  6:51 [PATCH -next] iw_cxgb4: make function read_tcb() static Wei Yongjun
@ 2019-02-18 11:24 ` Raju Rangoju
  2019-02-19 22:01 ` Jason Gunthorpe
  1 sibling, 0 replies; 3+ messages in thread
From: Raju Rangoju @ 2019-02-18 11:24 UTC (permalink / raw)
  To: kernel-janitors

On Monday, February 02/18/19, 2019 at 07:04:32 +0000, Wei Yongjun wrote:
> Fixes the following sparse warning:
> 
> drivers/infiniband/hw/cxgb4/cm.c:658:6: warning:
>  symbol 'read_tcb' was not declared. Should it be static?
> 
> Fixes: 11a27e2121a5 ("iw_cxgb4: complete the cached SRQ buffers")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/infiniband/hw/cxgb4/cm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index ae90b2932bd2..4d232bdf9e97 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -655,7 +655,7 @@ static int send_halfclose(struct c4iw_ep *ep)
>  	return c4iw_l2t_send(&ep->com.dev->rdev, skb, ep->l2t);
>  }
>  
> -void read_tcb(struct c4iw_ep *ep)
> +static void read_tcb(struct c4iw_ep *ep)
>  {
>  	struct sk_buff *skb;
>  	struct cpl_get_tcb *req;
> 
>
Acked-by: Raju Rangoju <rajur@chelsio.com>
> 

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH -next] iw_cxgb4: make function read_tcb() static
  2019-02-18  6:51 [PATCH -next] iw_cxgb4: make function read_tcb() static Wei Yongjun
  2019-02-18 11:24 ` Raju Rangoju
@ 2019-02-19 22:01 ` Jason Gunthorpe
  1 sibling, 0 replies; 3+ messages in thread
From: Jason Gunthorpe @ 2019-02-19 22:01 UTC (permalink / raw)
  To: kernel-janitors

On Mon, Feb 18, 2019 at 07:04:32AM +0000, Wei Yongjun wrote:
> Fixes the following sparse warning:
> 
> drivers/infiniband/hw/cxgb4/cm.c:658:6: warning:
>  symbol 'read_tcb' was not declared. Should it be static?
> 
> Fixes: 11a27e2121a5 ("iw_cxgb4: complete the cached SRQ buffers")
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/infiniband/hw/cxgb4/cm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Applied to for-next, thanks

Jason

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-02-19 22:01 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-18  6:51 [PATCH -next] iw_cxgb4: make function read_tcb() static Wei Yongjun
2019-02-18 11:24 ` Raju Rangoju
2019-02-19 22:01 ` Jason Gunthorpe

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).