* [PATCH] soc: qcom: cmd-db: Fix an error code in cmd_db_dev_probe()
@ 2019-02-28 5:48 Dan Carpenter
2019-03-01 19:07 ` Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Dan Carpenter @ 2019-02-28 5:48 UTC (permalink / raw)
To: Andy Gross, Mahesh Sivasubramanian
Cc: David Brown, linux-arm-msm, linux-kernel, kernel-janitors
The memremap() function doesn't return error pointers, it returns NULL.
This code is returning "ret = PTR_ERR(NULL);" which is success, but it
should return -ENOMEM.
Fixes: 312416d9171a ("drivers: qcom: add command DB driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
drivers/soc/qcom/cmd-db.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c
index c701b3b010f1..f6c3d17b05c7 100644
--- a/drivers/soc/qcom/cmd-db.c
+++ b/drivers/soc/qcom/cmd-db.c
@@ -248,8 +248,8 @@ static int cmd_db_dev_probe(struct platform_device *pdev)
}
cmd_db_header = memremap(rmem->base, rmem->size, MEMREMAP_WB);
- if (IS_ERR_OR_NULL(cmd_db_header)) {
- ret = PTR_ERR(cmd_db_header);
+ if (!cmd_db_header) {
+ ret = -ENOMEM;
cmd_db_header = NULL;
return ret;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] soc: qcom: cmd-db: Fix an error code in cmd_db_dev_probe()
2019-02-28 5:48 [PATCH] soc: qcom: cmd-db: Fix an error code in cmd_db_dev_probe() Dan Carpenter
@ 2019-03-01 19:07 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2019-03-01 19:07 UTC (permalink / raw)
To: Dan Carpenter
Cc: Andy Gross, Mahesh Sivasubramanian, David Brown, linux-arm-msm,
linux-kernel, kernel-janitors
On Wed 27 Feb 21:48 PST 2019, Dan Carpenter wrote:
> The memremap() function doesn't return error pointers, it returns NULL.
> This code is returning "ret = PTR_ERR(NULL);" which is success, but it
> should return -ENOMEM.
>
> Fixes: 312416d9171a ("drivers: qcom: add command DB driver")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
Thanks Dan, picking this up.
Regards,
Bjorn
> drivers/soc/qcom/cmd-db.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/soc/qcom/cmd-db.c b/drivers/soc/qcom/cmd-db.c
> index c701b3b010f1..f6c3d17b05c7 100644
> --- a/drivers/soc/qcom/cmd-db.c
> +++ b/drivers/soc/qcom/cmd-db.c
> @@ -248,8 +248,8 @@ static int cmd_db_dev_probe(struct platform_device *pdev)
> }
>
> cmd_db_header = memremap(rmem->base, rmem->size, MEMREMAP_WB);
> - if (IS_ERR_OR_NULL(cmd_db_header)) {
> - ret = PTR_ERR(cmd_db_header);
> + if (!cmd_db_header) {
> + ret = -ENOMEM;
> cmd_db_header = NULL;
> return ret;
> }
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-01 19:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-02-28 5:48 [PATCH] soc: qcom: cmd-db: Fix an error code in cmd_db_dev_probe() Dan Carpenter
2019-03-01 19:07 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).