From: Greg KH <gregkh@linuxfoundation.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH serial v4] sc16is7xx: missing unregister/delete driver on error in sc16is7xx_init()
Date: Wed, 20 Mar 2019 05:15:22 +0000 [thread overview]
Message-ID: <20190320051522.GC16864@kroah.com> (raw)
In-Reply-To: <20190320022531.189437-1-maowenan@huawei.com>
On Wed, Mar 20, 2019 at 10:25:31AM +0800, Mao Wenan wrote:
> Add the missing uart_unregister_driver() and i2c_del_driver() before
> return from sc16is7xx_init() in the error handling case.
>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> Reviewed-by: Vladimir Zapolskiy <vz@mleia.com>
> Reviewed-by: Dan Carpeter <dan.carpenter@oracle.com>
> Signed-off-by: Mao Wenan <maowenan@huawei.com>
> ---
> v1->v2: fix compile warning if CONFIG_SERIAL_SC16IS7XX_SPI is not exist.
> v2->v3: create functions for i2c and spi to do error handling as dan carpenter suggestion.
> v3->v4: As Greg suggestion, v4 is based on v1 and v3.
> drivers/tty/serial/sc16is7xx.c | 46 ++++++++++++++++++++++------------
Please use scripts/get_maintainers.pl for who to send patches to, and
what mailing list to cc: in the future.
thanks,
greg k-h
next prev parent reply other threads:[~2019-03-20 5:15 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 2:25 [PATCH serial v4] sc16is7xx: missing unregister/delete driver on error in sc16is7xx_init() Mao Wenan
2019-03-20 5:15 ` Greg KH [this message]
2019-03-20 6:13 ` maowenan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320051522.GC16864@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox