From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [PATCH] kvm: vmx: Silence a shift wrap warning
Date: Mon, 25 Mar 2019 09:04:48 +0000 [thread overview]
Message-ID: <20190325090448.GB16023@kadam> (raw)
This code generates a Smatch warning:
arch/x86/kvm/vmx/nested.c:4828 handle_vmfunc() warn: should '(1 << function)' be a 64 bit type?
The warning is generated because "vmcs12->vm_function_control" is a u64
but the shift can only test the lower 32 bits. This doesn't cause a
problem in the current code because we only use BIT(0). This patch just
silences the static checker warning.
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
---
arch/x86/kvm/vmx/nested.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/x86/kvm/vmx/nested.c b/arch/x86/kvm/vmx/nested.c
index f24a2c225070..1f4398246bd9 100644
--- a/arch/x86/kvm/vmx/nested.c
+++ b/arch/x86/kvm/vmx/nested.c
@@ -4825,7 +4825,7 @@ static int handle_vmfunc(struct kvm_vcpu *vcpu)
}
vmcs12 = get_vmcs12(vcpu);
- if ((vmcs12->vm_function_control & (1 << function)) = 0)
+ if ((vmcs12->vm_function_control & (1ULL << function)) = 0)
goto fail;
switch (function) {
--
2.17.1
next reply other threads:[~2019-03-25 9:04 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-25 9:04 Dan Carpenter [this message]
2019-03-25 9:29 ` [PATCH] kvm: vmx: Silence a shift wrap warning David Hildenbrand
2019-03-26 7:07 ` Dan Carpenter
2019-03-26 8:10 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325090448.GB16023@kadam \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox