From: Dan Carpenter <dan.carpenter@oracle.com>
To: Chris Wilson <chris@chris-wilson.co.uk>
Cc: kernel-janitors@vger.kernel.org, David Airlie <airlied@linux.ie>,
intel-gfx@lists.freedesktop.org,
Thomas Zimmermann <tdz@users.sourceforge.net>,
dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/selftests: Fix an IS_ERR() vs NULL check
Date: Tue, 26 Mar 2019 15:35:52 +0000 [thread overview]
Message-ID: <20190326153552.GJ32613@kadam> (raw)
In-Reply-To: <155361202926.15930.11426631316977293070@skylake-alporthouse-com>
On Tue, Mar 26, 2019 at 02:53:49PM +0000, Chris Wilson wrote:
> Quoting Mika Kuoppala (2019-03-26 09:30:57)
> > Dan Carpenter <dan.carpenter@oracle.com> writes:
> >
> > > The live_context() function returns error pointers. It never returns
> > > NULL.
> > >
> > > Fixes: 9c1477e83e62 ("drm/i915/selftests: Exercise adding requests to a full GGTT")
> > > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> >
> > Reviewed-by: Mika Kuoppala <mika.kuoppala@linux.intel.com>
> >
> > i915_request.c has another :)
>
> Having found it, you could have typed up the patch :-p
>
Smatch didn't warn about that one because we didn't dereference it right
away... I should make a check which complains about the condition
instead of the dereference.
regards,
dan carpenter
prev parent reply other threads:[~2019-03-26 15:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 5:08 [PATCH] drm/i915/selftests: Fix an IS_ERR() vs NULL check Dan Carpenter
2019-03-26 9:30 ` Mika Kuoppala
2019-03-26 14:53 ` Chris Wilson
2019-03-26 15:35 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190326153552.GJ32613@kadam \
--to=dan.carpenter@oracle.com \
--cc=airlied@linux.ie \
--cc=chris@chris-wilson.co.uk \
--cc=dri-devel@lists.freedesktop.org \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=tdz@users.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox