Re: [PATCH 1/2 net] NFC: nci: Add some bounds checking in nci_hci_cmd_received()

David Miller
2019-04-06T22:04:33Z

From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Wed, 3 Apr 2019 10:12:48 +0300

> This is similar to commit 674d9de02aa7 ("NFC: Fix possible memory
> corruption when handling SHDLC I-Frame commands").
>
> I'm not totally sure, but I think that commit description may have
> overstated the danger. I was under the impression that this data came
> from the firmware? If you can't trust your networking firmware, then
> you're already in trouble.
>
> Anyway, these days we add bounds checking where ever we can and we call
> it kernel hardening. Better safe than sorry.
>
> Fixes: 11f54f228643 ("NFC: nci: Add HCI over NCI protocol support")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>

Applied.