* Re: [5/7] cpufreq/pasemi: Checking implementation of pas_cpufreq_cpu_init()
[not found] <1554082674-2049-6-git-send-email-wen.yang99@zte.com.cn>
@ 2019-04-03 14:23 ` Markus Elfring
2019-04-03 15:31 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2019-04-03 14:23 UTC (permalink / raw)
To: Wen Yang, Rafael J. Wysocki, Viresh Kumar, kernel-janitors
Cc: linux-kernel, linux-pm, linuxppc-dev, Yi Wang
> @@ -146,6 +146,7 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy *policy)
>
> cpu = of_get_cpu_node(policy->cpu, NULL);
>
> + of_node_put(cpu);
> if (!cpu)
> goto out;
Can the statement “return -ENODEV” be nicer as exception handling
in the if branch of this source code place?
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/cpufreq/pasemi-cpufreq.c?id=bf97b82f37c6d90e16de001d0659644c57fa490d#n137
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [5/7] cpufreq/pasemi: Checking implementation of pas_cpufreq_cpu_init()
2019-04-03 14:23 ` [5/7] cpufreq/pasemi: Checking implementation of pas_cpufreq_cpu_init() Markus Elfring
@ 2019-04-03 15:31 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2019-04-03 15:31 UTC (permalink / raw)
To: Markus Elfring
Cc: Wen Yang, Rafael J. Wysocki, Viresh Kumar, kernel-janitors,
linux-kernel, linux-pm, linuxppc-dev, Yi Wang
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="windows-1254", Size: 786 bytes --]
On Wed, Apr 03, 2019 at 04:23:54PM +0200, Markus Elfring wrote:
> > @@ -146,6 +146,7 @@ static int pas_cpufreq_cpu_init(struct cpufreq_policy *policy)
> >
> > cpu = of_get_cpu_node(policy->cpu, NULL);
> >
> > + of_node_put(cpu);
> > if (!cpu)
> > goto out;
>
> Can the statement “return -ENODEV†be nicer as exception handling
> in the if branch of this source code place?
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/cpufreq/pasemi-cpufreq.c?id¿97b82f37c6d90e16de001d0659644c57fa490d#n137
>
Why am I only receiving only one side of this conversation?
I don't know why you're responding to... It's not required to fix/change
unrelated style choices. If people want, they can just focus on their
own thing.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-03 15:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1554082674-2049-6-git-send-email-wen.yang99@zte.com.cn>
2019-04-03 14:23 ` [5/7] cpufreq/pasemi: Checking implementation of pas_cpufreq_cpu_init() Markus Elfring
2019-04-03 15:31 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).