From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kalle Valo Date: Thu, 04 Apr 2019 10:21:09 +0000 Subject: Re: [PATCH] mwifiex: add a bounds check in mwifiex_process_sta_rx_packet() Message-Id: <20190404102109.EBBCE61948@smtp.codeaurora.org> List-Id: References: <20190402070338.GB15171@kadam> In-Reply-To: <20190402070338.GB15171@kadam> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Dan Carpenter Cc: Amitkumar Karwar , Nishant Sarmukadam , Ganapathi Bhat , Xinming Hu , linux-wireless@vger.kernel.org, kernel-janitors@vger.kernel.org Dan Carpenter wrote: > Smatch complains that "local_rx_pd->priority" can't be trusted because > it comes from skb->data and it can go up to 255 instead of being capped > in the 0-7 range. A few lines earlier, on the other side of the if > statement, we cap priority so it seems harmless to add a bounds check > here as well. > > Signed-off-by: Dan Carpenter > Reviewed-by: Brian Norris Patch applied to wireless-drivers-next.git, thanks. 2cd2b42439ea mwifiex: add a bounds check in mwifiex_process_sta_rx_packet() -- https://patchwork.kernel.org/patch/10881135/ https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches