* Re: [PATCH 1/3] net: xilinx: fix possible object reference leak
[not found] <1553223849-7143-1-git-send-email-wen.yang99@zte.com.cn>
@ 2019-04-05 7:54 ` Markus Elfring
2019-04-05 8:13 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Markus Elfring @ 2019-04-05 7:54 UTC (permalink / raw)
To: Wen Yang, David S. Miller, netdev, kernel-janitors
Cc: Yi Wang, Michal Simek, linux-kernel, Anirudha Sarangi, John Linn,
linux-arm-kernel
> @@ -1575,12 +1575,14 @@ static int axienet_probe(struct platform_device *pdev)
> ret = of_address_to_resource(np, 0, &dmares);
> if (ret) {
> dev_err(&pdev->dev, "unable to get DMA resource\n");
> + of_node_put(np);
> goto free_netdev;
> }
> lp->dma_regs = devm_ioremap_resource(&pdev->dev, &dmares);
> if (IS_ERR(lp->dma_regs)) {
> dev_err(&pdev->dev, "could not map DMA regs\n");
> ret = PTR_ERR(lp->dma_regs);
> + of_node_put(np);
> goto free_netdev;
> }
How do you think about to move these put calls to an additional
jump target for the desired exception handling?
https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/tree/drivers/net/ethernet/xilinx/xilinx_axienet_main.c?idú3a419d2f674b431d38748cb58fb7da17ee8949#n1621
Regards,
Markus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH 1/3] net: xilinx: fix possible object reference leak
2019-04-05 7:54 ` [PATCH 1/3] net: xilinx: fix possible object reference leak Markus Elfring
@ 2019-04-05 8:13 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2019-04-05 8:13 UTC (permalink / raw)
To: Markus Elfring
Cc: Yi Wang, Michal Simek, netdev, kernel-janitors, linux-kernel,
David S. Miller, Anirudha Sarangi, John Linn, Wen Yang,
linux-arm-kernel
Hi Markus,
Please don't add kernel-janitors to the CC list in the middle of the
conversation. Netdev people can review their own code. We don't have a
copy of the patch your discussing and it's not even clear who you're
responding to.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-04-05 8:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1553223849-7143-1-git-send-email-wen.yang99@zte.com.cn>
2019-04-05 7:54 ` [PATCH 1/3] net: xilinx: fix possible object reference leak Markus Elfring
2019-04-05 8:13 ` Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).