From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jozsef Kadlecsik <kadlec@blackhole.kfki.hu>,
Florian Westphal <fw@strlen.de>,
netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH v2] netfilter: nf_tables: prevent shift wrap in nft_chain_parse_hook()
Date: Sat, 13 Apr 2019 12:58:15 +0000 [thread overview]
Message-ID: <20190413125815.oiefilsilitqf2cm@salvia> (raw)
In-Reply-To: <20190406052652.GA20963@kadam>
On Sat, Apr 06, 2019 at 08:26:52AM +0300, Dan Carpenter wrote:
> I believe that "hook->num" can be up to UINT_MAX. Shifting more than
> 31 bits would is undefined in C but in practice it would lead to shift
> wrapping. That would lead to an array overflow in nf_tables_addchain():
>
> ops->hook = hook.type->hooks[ops->hooknum];
Applied, thanks.
prev parent reply other threads:[~2019-04-13 12:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-02 13:30 [PATCH] netfilter: nf_tables: prevent shift wrap in nft_chain_parse_hook() Dan Carpenter
2019-04-05 8:34 ` Dan Carpenter
2019-04-05 10:01 ` Florian Westphal
2019-04-06 5:26 ` [PATCH v2] " Dan Carpenter
2019-04-13 12:58 ` Pablo Neira Ayuso [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190413125815.oiefilsilitqf2cm@salvia \
--to=pablo@netfilter.org \
--cc=coreteam@netfilter.org \
--cc=dan.carpenter@oracle.com \
--cc=fw@strlen.de \
--cc=kadlec@blackhole.kfki.hu \
--cc=kernel-janitors@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox