From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH -next] serial: milbeaut_usio: Fix error handling in probe and remove
Date: Tue, 30 Apr 2019 09:35:26 +0000 [thread overview]
Message-ID: <20190430093526.GB2269@kadam> (raw)
In-Reply-To: <20190425151044.105045-1-weiyongjun1@huawei.com>
On Thu, Apr 25, 2019 at 03:10:44PM +0000, Wei Yongjun wrote:
> devm_clk_get() is used so there is no reason to explicitly call
> clk_put() in probe or remove functions.
Your patch is correct, but next time the patch description should be
more clear that this is a double free. To me the patch description
sounded like it was just tidying up or something instead of fixing a
crash. It might feel rude to say that the original code will crash, but
we are all human so introducing crashing bugs is not something to be
embarrassed about.
regards,
dan carpenter
prev parent reply other threads:[~2019-04-30 9:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-25 15:10 [PATCH -next] serial: milbeaut_usio: Fix error handling in probe and remove Wei Yongjun
2019-04-26 10:39 ` Sugaya, Taichi
2019-04-30 9:35 ` Dan Carpenter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190430093526.GB2269@kadam \
--to=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox