From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Luck, Tony" Date: Wed, 08 May 2019 22:48:07 +0000 Subject: Re: [PATCH] EDAC, sb_edac: remove redundant update of tad_base Message-Id: <20190508224807.GA25404@agluck-desk> List-Id: References: <20190508224201.27120-1-colin.king@canonical.com> In-Reply-To: <20190508224201.27120-1-colin.king@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Colin King Cc: Qiuxu Zhuo , Borislav Petkov , Mauro Carvalho Chehab , James Morse , linux-edac@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org On Wed, May 08, 2019 at 11:42:01PM +0100, Colin King wrote: > From: Colin Ian King > > The variable tad_base is being set to a value that is never read > and is being over-written on the next iteration of a for-loop. > This assignment is therefore redundant and can be removed. > > Addresses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King > --- > drivers/edac/sb_edac.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/edac/sb_edac.c b/drivers/edac/sb_edac.c > index 9353c3fc7c05..6aa4b1b73a15 100644 > --- a/drivers/edac/sb_edac.c > +++ b/drivers/edac/sb_edac.c > @@ -1513,7 +1513,6 @@ static int knl_get_dimm_capacity(struct sbridge_pvt *pvt, u64 *mc_sizes) > sad_actual_size[mc] += tad_size; > } > } > - tad_base = tad_limit+1; > } > } > Looks good to me. Acked-by: Tony Luck