From: Zhenyu Wang <zhenyuw@linux.intel.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: David Airlie <airlied@linux.ie>,
Aleksei Gimbitskii <aleksei.gimbitskii@intel.com>,
intel-gfx@lists.freedesktop.org, kernel-janitors@vger.kernel.org,
intel-gvt-dev@lists.freedesktop.org
Subject: Re: [PATCH] drm/i915/gvt: Fix an error code in ppgtt_populate_spt_by_guest_entry()
Date: Tue, 14 May 2019 06:56:26 +0000 [thread overview]
Message-ID: <20190514065626.GK12913@zhen-hp.sh.intel.com> (raw)
In-Reply-To: <20190513092244.GA12077@mwanda>
[-- Attachment #1: Type: text/plain, Size: 1100 bytes --]
On 2019.05.13 12:22:44 +0300, Dan Carpenter wrote:
> "ret" is uninitialized on this path but it should be -EINVAL.
>
> Fixes: 930c8dfea4b8 ("drm/i915/gvt: Check if get_next_pt_type() always returns a valid value")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/gpu/drm/i915/gvt/gtt.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/gvt/gtt.c b/drivers/gpu/drm/i915/gvt/gtt.c
> index 08c74e65836b..244ad1729764 100644
> --- a/drivers/gpu/drm/i915/gvt/gtt.c
> +++ b/drivers/gpu/drm/i915/gvt/gtt.c
> @@ -1076,8 +1076,10 @@ static struct intel_vgpu_ppgtt_spt *ppgtt_populate_spt_by_guest_entry(
> } else {
> int type = get_next_pt_type(we->type);
>
> - if (!gtt_type_is_pt(type))
> + if (!gtt_type_is_pt(type)) {
> + ret = -EINVAL;
> goto err;
> + }
>
> spt = ppgtt_alloc_spt_gfn(vgpu, type, ops->get_pfn(we), ips);
> if (IS_ERR(spt)) {
> --
Applied this, thanks!
--
Open Source Technology Center, Intel ltd.
$gpg --keyserver wwwkeys.pgp.net --recv-keys 4D781827
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 195 bytes --]
prev parent reply other threads:[~2019-05-14 6:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-13 9:22 [PATCH] drm/i915/gvt: Fix an error code in ppgtt_populate_spt_by_guest_entry() Dan Carpenter
2019-05-14 6:56 ` Zhenyu Wang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514065626.GK12913@zhen-hp.sh.intel.com \
--to=zhenyuw@linux.intel.com \
--cc=airlied@linux.ie \
--cc=aleksei.gimbitskii@intel.com \
--cc=dan.carpenter@oracle.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox