From: Leon Romanovsky <leon@kernel.org>
To: kernel-janitors@vger.kernel.org
Subject: Re: [PATCH] net/mlx5: potential error pointer dereference in error handling
Date: Tue, 28 May 2019 14:38:14 +0000 [thread overview]
Message-ID: <20190528143814.GQ4633@mtr-leonro.mtl.com> (raw)
In-Reply-To: <20190503122839.GB29695@mwanda>
On Fri, May 03, 2019 at 03:28:39PM +0300, Dan Carpenter wrote:
> The error handling was a bit flipped around. If the mlx5_create_flow_group()
> function failed then it would have resulted in dereferencing "fg" when
> it was an error pointer.
>
> Fixes: 80f09dfc237f ("net/mlx5: Eswitch, enable RoCE loopback traffic")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> drivers/net/ethernet/mellanox/mlx5/core/rdma.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Sorry for the delay, applied to mlx5-next branch.
6cc070bdf07c net/mlx5: potential error pointer dereference in error handling
Thanks
prev parent reply other threads:[~2019-05-28 14:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-03 12:28 [PATCH] net/mlx5: potential error pointer dereference in error handling Dan Carpenter
2019-05-28 14:38 ` Leon Romanovsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528143814.GQ4633@mtr-leonro.mtl.com \
--to=leon@kernel.org \
--cc=kernel-janitors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox