From: "Ville Syrjälä" <ville.syrjala@linux.intel.com>
To: YueHaibing <yuehaibing@huawei.com>
Cc: airlied@linux.ie, Hulk Robot <hulkci@huawei.com>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org, intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH -next] drm/i915/dsi: remove set but not used variable 'hfront_porch'
Date: Fri, 19 Jul 2019 17:23:35 +0000 [thread overview]
Message-ID: <20190719172335.GT5942@intel.com> (raw)
In-Reply-To: <20190719015136.103988-1-yuehaibing@huawei.com>
On Fri, Jul 19, 2019 at 01:51:36AM +0000, YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
>
> drivers/gpu/drm/i915/display/icl_dsi.c: In function 'gen11_dsi_set_transcoder_timings':
> drivers/gpu/drm/i915/display/icl_dsi.c:768:6: warning:
> variable 'hfront_porch' set but not used [-Wunused-but-set-variable]
>
> It is never used and can be removed.
>
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Thanks. Applied to drm-intel-next-queued.
> ---
> drivers/gpu/drm/i915/display/icl_dsi.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
> index 4d952accfaaa..a42348be0438 100644
> --- a/drivers/gpu/drm/i915/display/icl_dsi.c
> +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
> @@ -763,7 +763,7 @@ gen11_dsi_set_transcoder_timings(struct intel_encoder *encoder,
> enum transcoder dsi_trans;
> /* horizontal timings */
> u16 htotal, hactive, hsync_start, hsync_end, hsync_size;
> - u16 hfront_porch, hback_porch;
> + u16 hback_porch;
> /* vertical timings */
> u16 vtotal, vactive, vsync_start, vsync_end, vsync_shift;
>
> @@ -772,8 +772,6 @@ gen11_dsi_set_transcoder_timings(struct intel_encoder *encoder,
> hsync_start = adjusted_mode->crtc_hsync_start;
> hsync_end = adjusted_mode->crtc_hsync_end;
> hsync_size = hsync_end - hsync_start;
> - hfront_porch = (adjusted_mode->crtc_hsync_start -
> - adjusted_mode->crtc_hdisplay);
> hback_porch = (adjusted_mode->crtc_htotal -
> adjusted_mode->crtc_hsync_end);
> vactive = adjusted_mode->crtc_vdisplay;
>
>
--
Ville Syrjälä
Intel
prev parent reply other threads:[~2019-07-19 17:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-19 1:51 [PATCH -next] drm/i915/dsi: remove set but not used variable 'hfront_porch' YueHaibing
2019-07-19 17:23 ` Ville Syrjälä [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719172335.GT5942@intel.com \
--to=ville.syrjala@linux.intel.com \
--cc=airlied@linux.ie \
--cc=dri-devel@lists.freedesktop.org \
--cc=hulkci@huawei.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).