* [PATCH] iio: dac: ad5380: fix incorrect assignment to val
@ 2019-08-15 11:58 Colin King
2019-08-16 6:16 ` Ardelean, Alexandru
0 siblings, 1 reply; 4+ messages in thread
From: Colin King @ 2019-08-15 11:58 UTC (permalink / raw)
To: Lars-Peter Clausen, Michael Hennerich, Stefan Popa,
Jonathan Cameron, Hartmut Knaack, Peter Meerwald-Stadler,
linux-iio
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
Currently the pointer val is being incorrectly incremented
instead of the value pointed to by val. Fix this by adding
in the missing * indirection operator.
Addresses-Coverity: ("Unused value")
Fixes: c03f2c536818 ("staging:iio:dac: Add AD5380 driver")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/iio/dac/ad5380.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c
index 4335214800d2..2ebe08326048 100644
--- a/drivers/iio/dac/ad5380.c
+++ b/drivers/iio/dac/ad5380.c
@@ -220,7 +220,7 @@ static int ad5380_read_raw(struct iio_dev *indio_dev,
if (ret)
return ret;
*val >>= chan->scan_type.shift;
- val -= (1 << chan->scan_type.realbits) / 2;
+ *val -= (1 << chan->scan_type.realbits) / 2;
return IIO_VAL_INT;
case IIO_CHAN_INFO_SCALE:
*val = 2 * st->vref;
--
2.20.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: dac: ad5380: fix incorrect assignment to val
2019-08-15 11:58 [PATCH] iio: dac: ad5380: fix incorrect assignment to val Colin King
@ 2019-08-16 6:16 ` Ardelean, Alexandru
2019-08-18 17:55 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Ardelean, Alexandru @ 2019-08-16 6:16 UTC (permalink / raw)
To: Popa, Stefan Serban, linux-iio@vger.kernel.org, jic23@kernel.org,
colin.king@canonical.com, Hennerich, Michael, lars@metafoo.de,
knaack.h@gmx.de, pmeerw@pmeerw.net
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
T24gVGh1LCAyMDE5LTA4LTE1IGF0IDEyOjU4ICswMTAwLCBDb2xpbiBLaW5nIHdyb3RlOg0KPiBb
RXh0ZXJuYWxdDQo+IA0KDQpSZXZpZXdlZC1ieTogQWxleGFuZHJ1IEFyZGVsZWFuIDxhbGV4YW5k
cnUuYXJkZWxlYW5AYW5hbG9nLmNvbT4NCg0KPiBGcm9tOiBDb2xpbiBJYW4gS2luZyA8Y29saW4u
a2luZ0BjYW5vbmljYWwuY29tPg0KPiANCj4gQ3VycmVudGx5IHRoZSBwb2ludGVyIHZhbCBpcyBi
ZWluZyBpbmNvcnJlY3RseSBpbmNyZW1lbnRlZA0KPiBpbnN0ZWFkIG9mIHRoZSB2YWx1ZSBwb2lu
dGVkIHRvIGJ5IHZhbC4gRml4IHRoaXMgYnkgYWRkaW5nDQo+IGluIHRoZSBtaXNzaW5nICogaW5k
aXJlY3Rpb24gb3BlcmF0b3IuDQo+IA0KPiBBZGRyZXNzZXMtQ292ZXJpdHk6ICgiVW51c2VkIHZh
bHVlIikNCj4gRml4ZXM6IGMwM2YyYzUzNjgxOCAoInN0YWdpbmc6aWlvOmRhYzogQWRkIEFENTM4
MCBkcml2ZXIiKQ0KPiBTaWduZWQtb2ZmLWJ5OiBDb2xpbiBJYW4gS2luZyA8Y29saW4ua2luZ0Bj
YW5vbmljYWwuY29tPg0KPiAtLS0NCj4gIGRyaXZlcnMvaWlvL2RhYy9hZDUzODAuYyB8IDIgKy0N
Cj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigtKQ0KPiANCj4g
ZGlmZiAtLWdpdCBhL2RyaXZlcnMvaWlvL2RhYy9hZDUzODAuYyBiL2RyaXZlcnMvaWlvL2RhYy9h
ZDUzODAuYw0KPiBpbmRleCA0MzM1MjE0ODAwZDIuLjJlYmUwODMyNjA0OCAxMDA2NDQNCj4gLS0t
IGEvZHJpdmVycy9paW8vZGFjL2FkNTM4MC5jDQo+ICsrKyBiL2RyaXZlcnMvaWlvL2RhYy9hZDUz
ODAuYw0KPiBAQCAtMjIwLDcgKzIyMCw3IEBAIHN0YXRpYyBpbnQgYWQ1MzgwX3JlYWRfcmF3KHN0
cnVjdCBpaW9fZGV2ICppbmRpb19kZXYsDQo+ICAJCWlmIChyZXQpDQo+ICAJCQlyZXR1cm4gcmV0
Ow0KPiAgCQkqdmFsID4+PSBjaGFuLT5zY2FuX3R5cGUuc2hpZnQ7DQo+IC0JCXZhbCAtPSAoMSA8
PCBjaGFuLT5zY2FuX3R5cGUucmVhbGJpdHMpIC8gMjsNCj4gKwkJKnZhbCAtPSAoMSA8PCBjaGFu
LT5zY2FuX3R5cGUucmVhbGJpdHMpIC8gMjsNCj4gIAkJcmV0dXJuIElJT19WQUxfSU5UOw0KPiAg
CWNhc2UgSUlPX0NIQU5fSU5GT19TQ0FMRToNCj4gIAkJKnZhbCA9IDIgKiBzdC0+dnJlZjsNCg=
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: dac: ad5380: fix incorrect assignment to val
2019-08-16 6:16 ` Ardelean, Alexandru
@ 2019-08-18 17:55 ` Jonathan Cameron
2019-08-27 20:03 ` Jonathan Cameron
0 siblings, 1 reply; 4+ messages in thread
From: Jonathan Cameron @ 2019-08-18 17:55 UTC (permalink / raw)
To: Ardelean, Alexandru
Cc: Popa, Stefan Serban, linux-iio@vger.kernel.org,
colin.king@canonical.com, Hennerich, Michael, lars@metafoo.de,
knaack.h@gmx.de, pmeerw@pmeerw.net,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
On Fri, 16 Aug 2019 06:16:26 +0000
"Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
> On Thu, 2019-08-15 at 12:58 +0100, Colin King wrote:
> > [External]
> >
>
> Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
Applied to the fixes-togreg branch of iio.git.
Thanks,
Jonathan
>
> > From: Colin Ian King <colin.king@canonical.com>
> >
> > Currently the pointer val is being incorrectly incremented
> > instead of the value pointed to by val. Fix this by adding
> > in the missing * indirection operator.
> >
> > Addresses-Coverity: ("Unused value")
> > Fixes: c03f2c536818 ("staging:iio:dac: Add AD5380 driver")
> > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > ---
> > drivers/iio/dac/ad5380.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c
> > index 4335214800d2..2ebe08326048 100644
> > --- a/drivers/iio/dac/ad5380.c
> > +++ b/drivers/iio/dac/ad5380.c
> > @@ -220,7 +220,7 @@ static int ad5380_read_raw(struct iio_dev *indio_dev,
> > if (ret)
> > return ret;
> > *val >>= chan->scan_type.shift;
> > - val -= (1 << chan->scan_type.realbits) / 2;
> > + *val -= (1 << chan->scan_type.realbits) / 2;
> > return IIO_VAL_INT;
> > case IIO_CHAN_INFO_SCALE:
> > *val = 2 * st->vref;
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] iio: dac: ad5380: fix incorrect assignment to val
2019-08-18 17:55 ` Jonathan Cameron
@ 2019-08-27 20:03 ` Jonathan Cameron
0 siblings, 0 replies; 4+ messages in thread
From: Jonathan Cameron @ 2019-08-27 20:03 UTC (permalink / raw)
To: Ardelean, Alexandru
Cc: Popa, Stefan Serban, linux-iio@vger.kernel.org,
colin.king@canonical.com, Hennerich, Michael, lars@metafoo.de,
knaack.h@gmx.de, pmeerw@pmeerw.net,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
On Sun, 18 Aug 2019 18:55:44 +0100
Jonathan Cameron <jic23@kernel.org> wrote:
> On Fri, 16 Aug 2019 06:16:26 +0000
> "Ardelean, Alexandru" <alexandru.Ardelean@analog.com> wrote:
>
> > On Thu, 2019-08-15 at 12:58 +0100, Colin King wrote:
> > > [External]
> > >
> >
> > Reviewed-by: Alexandru Ardelean <alexandru.ardelean@analog.com>
> Applied to the fixes-togreg branch of iio.git.
I changed my mind on this because I've been a bit slow sending a pull
request and we are now at rc6. Hence I've cherry picked it into
togreg so it'll go in during the next merge window and get backported
at that point.
Thanks,
Jonathan
>
> Thanks,
>
> Jonathan
>
> >
> > > From: Colin Ian King <colin.king@canonical.com>
> > >
> > > Currently the pointer val is being incorrectly incremented
> > > instead of the value pointed to by val. Fix this by adding
> > > in the missing * indirection operator.
> > >
> > > Addresses-Coverity: ("Unused value")
> > > Fixes: c03f2c536818 ("staging:iio:dac: Add AD5380 driver")
> > > Signed-off-by: Colin Ian King <colin.king@canonical.com>
> > > ---
> > > drivers/iio/dac/ad5380.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/iio/dac/ad5380.c b/drivers/iio/dac/ad5380.c
> > > index 4335214800d2..2ebe08326048 100644
> > > --- a/drivers/iio/dac/ad5380.c
> > > +++ b/drivers/iio/dac/ad5380.c
> > > @@ -220,7 +220,7 @@ static int ad5380_read_raw(struct iio_dev *indio_dev,
> > > if (ret)
> > > return ret;
> > > *val >>= chan->scan_type.shift;
> > > - val -= (1 << chan->scan_type.realbits) / 2;
> > > + *val -= (1 << chan->scan_type.realbits) / 2;
> > > return IIO_VAL_INT;
> > > case IIO_CHAN_INFO_SCALE:
> > > *val = 2 * st->vref;
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-08-27 20:03 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-15 11:58 [PATCH] iio: dac: ad5380: fix incorrect assignment to val Colin King
2019-08-16 6:16 ` Ardelean, Alexandru
2019-08-18 17:55 ` Jonathan Cameron
2019-08-27 20:03 ` Jonathan Cameron
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).