* Re: [PATCH] staging: vt6655: Fix memory leak in vt6655_probe
[not found] <20191004200319.22394-1-navid.emamdoost@gmail.com>
@ 2019-10-05 16:30 ` Markus Elfring
2019-10-05 18:40 ` Greg Kroah-Hartman
0 siblings, 1 reply; 3+ messages in thread
From: Markus Elfring @ 2019-10-05 16:30 UTC (permalink / raw)
To: Navid Emamdoost, devel
Cc: kernel-janitors, Malcolm Priestley, Greg Kroah-Hartman,
Kangjie Lu, linux-kernel, Madhumitha Prabakaran, Luis Chamberlain,
Navid Emamdoost, Forest Bond, Stephen McCamant
> In vt6655_probe, if vnt_init() fails the cleanup code needs to be called
> like other error handling cases. The call to device_free_info() is
> added.
Please improve this change description.
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] staging: vt6655: Fix memory leak in vt6655_probe
2019-10-05 16:30 ` [PATCH] staging: vt6655: Fix memory leak in vt6655_probe Markus Elfring
@ 2019-10-05 18:40 ` Greg Kroah-Hartman
2019-10-06 5:39 ` Markus Elfring
0 siblings, 1 reply; 3+ messages in thread
From: Greg Kroah-Hartman @ 2019-10-05 18:40 UTC (permalink / raw)
To: Markus Elfring
Cc: devel, Malcolm Priestley, kernel-janitors, Kangjie Lu,
linux-kernel, Madhumitha Prabakaran, Luis Chamberlain,
Navid Emamdoost, Forest Bond, Stephen McCamant, Navid Emamdoost
On Sat, Oct 05, 2019 at 06:30:13PM +0200, Markus Elfring wrote:
> > In vt6655_probe, if vnt_init() fails the cleanup code needs to be called
> > like other error handling cases. The call to device_free_info() is
> > added.
>
> Please improve this change description.
It is fine as-is, please do not confuse people.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: staging: vt6655: Fix memory leak in vt6655_probe
2019-10-05 18:40 ` Greg Kroah-Hartman
@ 2019-10-06 5:39 ` Markus Elfring
0 siblings, 0 replies; 3+ messages in thread
From: Markus Elfring @ 2019-10-06 5:39 UTC (permalink / raw)
To: Greg Kroah-Hartman, Navid Emamdoost, devel, kernel-janitors
Cc: Malcolm Priestley, Kangjie Lu, linux-kernel,
Madhumitha Prabakaran, Luis Chamberlain, Navid Emamdoost,
Forest Bond, Stephen McCamant
>>> In vt6655_probe, if vnt_init() fails the cleanup code needs to be called
>>> like other error handling cases. The call to device_free_info() is
>>> added.
>>
>> Please improve this change description.
>
> It is fine as-is, please do not confuse people.
Would you like to clarify a known guideline once more?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=43b815c6a8e7dbccb5b8bd9c4b099c24bc22d135#n151
“…
Describe your changes in imperative mood,
…”
Regards,
Markus
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-06 5:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20191004200319.22394-1-navid.emamdoost@gmail.com>
2019-10-05 16:30 ` [PATCH] staging: vt6655: Fix memory leak in vt6655_probe Markus Elfring
2019-10-05 18:40 ` Greg Kroah-Hartman
2019-10-06 5:39 ` Markus Elfring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).